Fix exception not created from HEAD requests #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jun 11, 2024
|
The CI failure on PHP 8.4 is because of deprecations triggered by PHP in the symfony/polyfill code. This is solved in symfony/polyfill#467 but not released yet |
|
And the root tests were broken by #1722 which has been merged with a failing CI |
jderusse
force-pushed
the
exception-withoutbody
branch
2 times, most recently
from
af34a76
to
4c81482
Compare
jderusse
force-pushed
the
exception-withoutbody
branch
from
4c81482
to
8e27ecf
Compare
|
For the failure in root tests, I opened #1726 to fix it. |
tests are green except for 8.4 because of deprecation in polyfill |
stof
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1723
IIUC the manifest, all errors are "linked" to a
httpStatusCode, but we don't check it.We might need a deep refactor that:
any opinion?