Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc warnings #5

Closed
skade opened this issue Aug 12, 2019 · 2 comments
Closed

Fix doc warnings #5

skade opened this issue Aug 12, 2019 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@skade
Copy link
Collaborator

skade commented Aug 12, 2019

We should make a pass over the docs soon, making sure they are free of warnings.
@skade skade added the documentation Improvements or additions to documentation label Aug 12, 2019
@ghost
Copy link

ghost commented Aug 14, 2019

We now have the following lines in lib.rs that take care of warnings in doc tests:

#![doc(test(attr(deny(rust_2018_idioms, warnings))))]
#![doc(test(attr(allow(unused_extern_crates, unused_variables))))]

@skade
Copy link
Collaborator Author

skade commented Aug 14, 2019

Confirmed, warnings are fixed in async-std.

@skade skade closed this as completed Aug 14, 2019
@link2xt link2xt mentioned this issue Oct 22, 2020
Open
moh-eulith pushed a commit to moh-eulith/async-std that referenced this issue Mar 31, 2022
Merge pull request async-rs#5 from Keruspe/optimistic-rw
e5a174a 
skip optimistic read/write when there already are wakers registered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skade