-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some modules support no_std #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredibly cool! @k-nasa what's left for this PR before we can merge?
@yoshuawuyts However, I think it is necessary to add no_std examples and documentation in the future. Or should it be done now? |
I couldn't build with target
I ran command output is
@taiki-e Do you know any solution? |
Looks like due to rust-lang/cargo#4866 (cargo leaking *-dependencies into normal build) Could you add (if we need to run on stable, use cargo-hack's |
@taiki-e Thanks!! |
cfg_std! { | ||
pub use pending::pending; | ||
pub use poll_fn::poll_fn; | ||
pub use ready::ready; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: to enable these utilities on no-std, use manually implemented futures instead of async functions.
Is it a problem to merge this? |
@k-nasa fantastic work; this is great! |
@yoshuawuyts it seems like an autocompletion failure? ;) |
@tirr-c ahaha, oops context switch failure. Was also reviewing Tide patches 😂 sorry sorry! |
The following three modules have been changed to work with no_std.