feat: removing v3 check for bundle command #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Souvikns
requested review from
magicmatatjahu,
derberg and
asyncapi-bot-eve
as code owners
smoya
suggested changes
Feb 2, 2024
derberg
reviewed
Feb 27, 2024
|
this was an unfortunate asyncapi/cli limitation to run into after converting my spec from 2.6.0 -> 3.0.0. is there anything I can assist with to help land this feature soon? or are we just waiting on the maintainer code review? |
Souvikns
changed the title
derberg
approved these changes
Mar 15, 2024
|
|
/rtm |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V3 check was put on all commands in CLI to prevent compiling v3 spec if the tool didn't support it yet. Since bundler now supports spec V3 this PR is removing that check from the CLI.
Related issue(s)
Fixes #1137