Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate linter in project #29

Closed
magicmatatjahu opened this issue Jul 16, 2021 · 7 comments · Fixed by #32
Closed

Integrate linter in project #29

magicmatatjahu opened this issue Jul 16, 2021 · 7 comments · Fixed by #32
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@magicmatatjahu
Copy link
Member

As project is written in JS we should integrate eslint linter in project like in other our repos.

AC:

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Jul 16, 2021
@github-actions
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@aayushmau5
Copy link
Member

aayushmau5 commented Jul 16, 2021

Can this be considered as a Good First Issue?

@Souvikns
Copy link
Member

@magicmatatjahu should I put this in #28 PR or create a different PR.

@magicmatatjahu
Copy link
Member Author

@Souvikns No, it should be done as separate PR.

@aayushmau5 Good idea, I will add the label :)

@magicmatatjahu magicmatatjahu added the good first issue Good for newcomers label Jul 19, 2021
@Souvikns
Copy link
Member

@magicmatatjahu shall work on this issue next?

@magicmatatjahu
Copy link
Member Author

@Souvikns If you want, go ahead :)

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants