Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TS in hooks and filters #455

Closed
magicmatatjahu opened this issue Dec 8, 2020 · 3 comments · Fixed by #519
Closed

Support TS in hooks and filters #455

magicmatatjahu opened this issue Dec 8, 2020 · 3 comments · Fixed by #519
Labels
enhancement New feature or request

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Dec 8, 2020 •
edited
Loading

Reason/Context

At the moment generator doesn't support TS in hooks and filters. Problematic is that if someone wants to use TS in template he/she can't, because mentioned hooks and filters won't work due to handle them by generator itself, so generator should handle transpilation to JS before rendering process.

Description

I don't think it will be a breaking change. We should do something like that https://github.com/kyma-project/website/blob/master/gatsby/index.js#L3 so before saving filters to nunjucks we should transpile TS code to JS code. This same for hooks.
@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Dec 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

Welcome to AsyncAPI. Thanks a lot for reporting your first issue.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@magicmatatjahu magicmatatjahu mentioned this issue Dec 9, 2020
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Feb 8, 2021
@magicmatatjahu magicmatatjahu mentioned this issue Mar 1, 2021
Merged
@fmvilas
Copy link
Member

fmvilas commented Mar 4, 2021

Problematic is that if someone wants to use TS in template he/she can't...

I'm curious how many times this has been a problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add TypeScript support for hooks and filters magicmatatjahu/generator
2 participants
@fmvilas @magicmatatjahu