Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support
noOverwriteGlobs
for templates based on react #1191feat: support
noOverwriteGlobs
for templates based on react #1191Changes from 16 commits
fc81484
94c04b5
4bccad3
57ec2ee
8333600
d467476
4999885
19e11df
c0b9ec8
d147b9f
7dd724f
1ff0f22
98a1e71
e9f5bd0
695e960
3bb9e6f
6aa3b59
380e210
1b638a2
30bf2f6
a7930b8
2e8dda6
1047cda
a3c0a86
95d44f8
2e6cd81
36815ce
655d39b
e075fff
a94fd00
cd22f3e
2117147
6ae0b80
33eb3e5
ca40710
332a4ed
214387a
e5db0f6
3505053
c4f29c2
038c130
b2fa883
15629dc
5e49121
a23636a
55f9ae7
900faa9
3e7afe7
b3b29a1
6854f6b
fbd41c8
09e7882
49c8952
eebca77
2f3a3ef
f5a6251
0385f26
be28dea
12ada05
06848d4
1ec96a4
61d795a
f5180b7
4305a9c
ce41fe0
c741598
2ee44db
2d77e3c
47ae19b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually I don't get why we need to validate if it exists, if a line earlier it is created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly,
generateFolderName()
does not actually generate the directory, but just creates and returns a path string. Thus I manually checks and creates it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that in other tests you have written, you did not check and create the directory. Did you not have directory or path not found issue? If I comment out line 78-80, I have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it better to add the string to variable and not repeat it in line 82?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not relevant anymore