Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add new Usage document #842

Merged
merged 33 commits into from
Nov 14, 2022
Merged

Conversation

Florence-Njeri
Copy link
Collaborator

@Florence-Njeri Florence-Njeri commented Sep 26, 2022

Description
Usage of the async api CLI.

Related issue(s)
Fixes #810

@Florence-Njeri Florence-Njeri marked this pull request as ready for review September 26, 2022 17:41
@Florence-Njeri
Copy link
Collaborator Author

Hey @alequetzalli, @derberg, @pratik2315, @Annysah, @starlightknown, @nelsonmic, @thulieblack this PR is ready for review.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good @Florence-Njeri

  • we just need to remove the content from readme, and link to this new document
  • and we need to update commands, look ❤️ feat: add generate fromTemplate command cli#221 ❤️ it happened 🚀 so all ag now become asyncapi generate fromTemplate

docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Copy link
Member

@alequetzalli alequetzalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Florence-Njeri just a few items... thank you again for another doc!!!! Your contributions are so helpful! ✨✨✨

Florence-Njeri and others added 8 commits October 2, 2022 21:41
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
alequetzalli
alequetzalli previously approved these changes Oct 19, 2022
Copy link
Member

@alequetzalli alequetzalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg
Copy link
Member

derberg commented Oct 20, 2022

@Florence-Njeri also, I noticed you have 3 PRs with new docs, and all contribute to changes in readme TOC.

I do not mind if you decide to ignore and not do these in these 3 PRs and do it in a 4th followup. Why? because if you do it in your PRs you will for sure get merge conflicts, and it is good to avoid them. Unless you never had to deal with them, so I recommend you ignore what I wrote just above, and confront merge conflicts to get experience 😄

derberg
derberg previously approved these changes Nov 8, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli wanna approve before we merge?

@derberg derberg changed the title docs: usage docs: add new Usage document Nov 8, 2022
alequetzalli
alequetzalli previously approved these changes Nov 9, 2022
Copy link
Member

@alequetzalli alequetzalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢 🚢 🚢 🚢 🚢

derberg
derberg previously approved these changes Nov 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Nov 14, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit e473f53 into asyncapi:master Nov 14, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants