-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new Usage document #842
Conversation
Hey @alequetzalli, @derberg, @pratik2315, @Annysah, @starlightknown, @nelsonmic, @thulieblack this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good @Florence-Njeri
- we just need to remove the content from readme, and link to this new document
- and we need to update commands, look ❤️ feat: add generate fromTemplate command cli#221 ❤️ it happened 🚀 so all
ag
now becomeasyncapi generate fromTemplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Florence-Njeri just a few items... thank you again for another doc!!!! Your contributions are so helpful! ✨✨✨
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only need to add it to https://github.com/asyncapi/generator/tree/master/docs
@Florence-Njeri also, I noticed you have 3 PRs with new docs, and all contribute to changes in readme TOC. I do not mind if you decide to ignore and not do these in these 3 PRs and do it in a 4th followup. Why? because if you do it in your PRs you will for sure get merge conflicts, and it is good to avoid them. Unless you never had to deal with them, so I recommend you ignore what I wrote just above, and confront merge conflicts to get experience 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli wanna approve before we merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢 🚢 🚢 🚢 🚢
ee92c27
Kudos, SonarCloud Quality Gate passed!
|
/rtm |
🎉 This PR is included in version 1.9.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Usage of the async api CLI.
Related issue(s)
Fixes #810