-
-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new tutorial "generate code" #1025
docs: new tutorial "generate code" #1025
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Hello @alequetzalli and @derberg , I would love your feedbacks. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1025--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Annysah yo, left some feedback.
@alequetzalli just thinking, if in case of this split of streetlight tutorial, maybe we should have a separate branch, as I think it only makes sense to release all of them at once
@derberg Thank you for all the suggested changes. I just implemented them. |
pingy pongo @derberg 😬😬😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for delayed review, conference occupied me a lot last days before it.
left some comments
Hey @Annysah, please review and make sure you resolve all comments in this PR when you address the feedback. It is confusing as it currently stands. 😄 |
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
oh yikes, I missed that! fixing O_O |
ooookay so @derberg my findings...
|
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
yo @derberg, so I accepted your commit suggestion fix but it didn't fix the problem :( cry https://deploy-preview-1025--asyncapi-website.netlify.app/docs/tutorials/generate-code |
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
/rtm |
Description
This is the second part of the streetlights tutorial which describes how to "generate code" from the specification document.
Related issue(s)
Fixes #1010