Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Error Messaging for Missing Auth Function #688

Closed
KhudaDad414 opened this issue Jan 17, 2024 · 4 comments · Fixed by #695
Closed

Improved Error Messaging for Missing Auth Function #688

KhudaDad414 opened this issue Jan 17, 2024 · 4 comments · Fixed by #695
Labels
enhancement New feature or request released

Comments

@KhudaDad414
Copy link
Member

Context

While working with the Glee framework, I encountered a WebSocket client error when there was no authentication function present. The current error message does not specify which function is missing or the exact location in the code where the function is expected to be.

Error Encountered

x WebSocket client error on channel 'SlackEventStream'
at WebSocket.<anonymous> (file:///Users/khudadad/Projects/asyncapi/glee.worktrees/fix-websocket-bug/dist/adapters/ws/client.js:76:40)
...

Expected Behavior

When the framework encounters a missing authentication function, it would be beneficial for the error message to clearly state which specific function is missing and in which file. For instance, an error message like:

Error: Authentication function not found in `auth/Slack_Server`. Expected function `clientAuth`.
@KhudaDad414 KhudaDad414 added the enhancement New feature or request label Jan 17, 2024
@srini047
Copy link
Contributor

srini047 commented Jan 17, 2024

@KhudaDad414 If this issue is open to contributing I would like to take this up.

Find it interesting and good first contribution to Glee.

@Gmin2
Copy link

Gmin2 commented Jan 17, 2024

@KhudaDad414 may i give it a go?

@KhudaDad414
Copy link
Member Author

I guess we should go on the First Come First Serve basis. Sorry @Min2who.

@srini047 Please open a PR fixing the issue. If you need help, please reach out.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.35.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants