-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace server.url with server.host #547
Comments
Thanks for putting the issue together! This is indeed a glitch of the existing spec ( The OpenAPI Server Object does not have a protocol field, which makes sense since the protocol can be inferred from the So this proposal is essentially dropping support for relative server URLs. |
Instead of dropping the The enforcement of the absolute url will provide support for all possible URL parts (even for niche parts such as To me, this feels like the most simple and future proof approach. |
🤔 Enforcing the URL to be always absolute would go against our plans to support any kind of APIs in the future (REST too). Just thinking out loud: another option is that we decide to take both approaches and do something like "use |
I see. In that case, I think I lean towards your proposal: drop the URL field, and replace it with fields for all the possible URL parts. |
Happy to champion this RFC by the way. Will be putting together a Stage 1 proposal. |
This issue has been automatically marked as stale because it has not had recent activity 😴 |
I think this makes sense to include in 3.0.0. My only concern is that it becomes difficult for tooling to access the full URL. As you rarely need to access the individual components of the full URL, tooling would have to remember how to glue together the pieces of information. Added a clarification issue for the parser-api to ensure we don't forget to solve this for tooling - asyncapi/parser-api#37 |
Is there any of you who wants to champion this? 🙂 Or can we consider this issue as needs champion? 🤔 |
Anything addressing this issue should be required to also resolve #274, which basically stems from the fact that any bare host name is also syntactically a valid URI reference (e.g., in the absence of documented priority for interpreting the data, it is ambiguous whether |
@dedoussis are you happy championing this one as you mentioned in the past? |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@fmvilas what about this one? Do we want to move it forward or rather stale it finally? |
I think this should be addressed in the next major version, otherwise, it will produce a breaking change. Or! We leave it for 4.0.0 and see how well the parser intent-driven API behaves 😄 |
I made a proposal for this issue: #888. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Be patient, dear Github Actions. The PR is done and it will make it to 3.0.0. Just give us some more time :) |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Problem
Currently, AsyncAPI servers have a property called
url
. In many cases, we're showing examples of theurl
field as a host instead (without the protocol part of the URL) which is incorrect. On top of that, what's the point of having the protocol included in theurl
field if we already have theprotocol
field? This is an example of what I'm talking about:It can also create inconsistencies where the protocol in the URL and the
protocol
field don't match:Proposal
My proposal is that we rename the
url
field ashost
, which would be more correct. Example:We may also have to consider adding other parts of the URL like the path and query variables.
This is a proposal to fix #274
The text was updated successfully, but these errors were encountered: