New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the getting started docs page #825
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-825--asyncapi-website.netlify.app/ |
pages/docs/getting-started/index.md
Outdated
aliases: | ||
- '/v1/guide/' | ||
- '/v1/guide/index.html' | ||
--- | ||
|
||
AsyncAPI is an open source initiative that seeks to improve the current state of Event-Driven Architectures (EDA). Our long-term goal is to make working with EDAs as easy as it is to work with REST APIs. That goes from documentation to code generation, from discovery to event management. Most of the processes you apply to your REST APIs nowadays would be applicable to your event-driven/asynchronous APIs too. | ||
Welcome to the AysncAPI documentation section where you get to learn about solutions to automate and formalize the documentation or code generation of your event-driven (micro)services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this introduction needs to be an introduction to the tutorial, not the spec. 😸 Let's update this section to detail what this tutorial is going to teach us and what we are going to build.
⭐ For a tutorial introduction, you want to describe:
- what the user will build (list technologies and end goal)
- overview of main steps to build it
- what the user will learn
Let's go ahead and give this section another go 😃
pages/docs/getting-started/index.md
Outdated
|
||
|
||
## Summary | ||
In this tutorial, we were able to learn how to setup an AsyncAPI document from scratch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸 For the Summary section in our tutorials, we are writing:
- a summary of what the user just built and what technologies were used (again)
- an explanation of what the user learned to do
A big part of improving this tutorial means both re-writing and adding new content ❤️ based on our new IA goals.
pages/docs/getting-started/index.md
Outdated
> The AsyncAPI specification settles the base for a greater and better tooling ecosystem for EDA's. | ||
|
||
## Installation Guide | ||
In order to successfully set up AsyncAPI, you'll need to download a few things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to successfully set up AsyncAPI, you'll need to download a few things: | |
Before you proceed to the next stage, you'll need to download a few things: |
pages/docs/getting-started/index.md
Outdated
In this tutorial, we were able to learn how to setup an AsyncAPI document from scratch. | ||
|
||
## Next Steps | ||
Now that you've completed this tutorial, check out our [Streetlights](https://www.asyncapi.com/docs/tutorials/streetlights) tutorial to learn how to create a basic practical example of a system that can turn on and off streetlights with AsyncAPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you've completed this tutorial, check out our [Streetlights](https://www.asyncapi.com/docs/tutorials/streetlights) tutorial to learn how to create a basic practical example of a system that can turn on and off streetlights with AsyncAPI. | |
Now that you've completed this tutorial, check out our [Streetlights](https://www.asyncapi.com/docs/tutorials/streetlights) tutorial to learn how to create a sample IoT system that turns streetlights on and off with AsyncAPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start @Annysah! 🎉🎉🎉
Let's go for Draft 2. ❤️
Thanks Ale for the reviews, I will get to work! |
Hi @alequetzalli, Just submitted the second draft. |
In addition to the requested changes, I added a section "Generating the docs". Would it be a necessary addition? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'll definitely have a look, but please first solve the merge conflicts, and then ping me again so I know it is ready for review (sometimes things get messy during solving conflicts, so better if i look after) |
Alright @derberg, I will work on resolving it. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik the document that you edit here in this PR is https://www.asyncapi.com/docs/tutorials/getting-started and I'm not 100% sure we really want to turn it into a tutorial. I think this should be a kind of intro to getting started, so it is now.
now this document at the same time contains a general explanation of AsyncAPI goal (was there before) and some step-by-step explanation on how to create an AsyncAPI document + generate docs for it. Technically your instructions are very accurate but was it the goal. The Getting Started index document is on the upper level of all the getting started tutorials. If feels confusing that in upper level we create asyncapi file and generate docs, and then we create new asyncapi document again, with different protocol.
I'm not sure you know what I mean. I think the focus should go on these documents 👇🏼
to make sure there is a flow, that more AsyncAPI spec features (objects) are explained step by step, that examples (if possible) are based on the same app example, so they are consistent (not https://www.asyncapi.com/docs/tutorials/getting-started/asyncapi-documents is not consistent with the rest)
maybe let's go back to #793 and clarify the scope there? @alequetzalli thoughts?
.......... @derberg Ok dude.... First, this is SO CONFUSING in the way you wrote it, you need to slow down and breathe before you reply to stuff. 😝 (just explaining cause you really confused poor @Annysah, so I am trying to help clarify to her what you said 😄✌🏽) Second, Seeing what Anisat wrote in her 2nd draft here + thinking of your feedback Lukasz, I am inclined to agree that this Getting Started is really a quickstart, and not a tutorial. If yes, if we consider it a quickstart, that also means the TW outline is not going to be the same as the outline for a tutorial and thus does not need to change. So IOW @Annysah, what Lukasz was expressing is that what you wrote/added in this PR is technically accurate, BUT potentially did not make sense to incorporate because his take was that this piece of TW content was not a tutorial. (Now you can see why I emphasized so much in the previous paragraph that I agreed this was a quickstart to the technology of AsyncAPI.) Since a quickstart to the technology of AsyncAPI is a different kind of TW content, the goals and outline will be different than that which is needed for a tutorial that explains things you can do with the technology of AsyncAPI. 😀✌🏽 Lastly, what this means is that I don't think we actually need to merge this PR and it actually makes sense to close it, Anisat. 😀✌🏽 This doesn't mean you didn't do a GOOD job! I think it was pretty good and like Lukasz even himself said, what you added was technically correct. And that's always a good thing! haha 😎 Essentially, Lukasz was just seeing that this is one of those PRs that after the fact, you happen to realize is not the best idea to merge for a project. Not a big deal and it was still SUPER GOOD to have you practice writing and getting more familiar with AsyncAPI. 😀❤️ let me know if this makes sense now 😀 @Annysah! and I think it could be as simple as us closing this PR (unless lukasz had diff thoughts) and then we identify a new task for you (which there is! hahaha trust meee)
No lukasz, the scope there is clear; it's a tutorial update with new outline template. I think you just got confused because you don't think of this as a tutorial. (which we agree on hahaa) |
ups, sorry for being confusing. I actually did not rush with my comment, on a contrary, I tried to be as detailed as possible to express my confusion 😆 because the content, as I wrote, was technically accurate, but the location was confusing and I could not figure much from linked issue. I think it is a good idea to have a kind of tutorial, that is super straightforward, just few steps, from creating a file to generating docs. Let's just first discuss the scope in an issue first, because for example I think it would be lovely to use AsyncAPI CLI for it, where you have the |
Thank you so much @alequetzalli for the clarifications. I think I now understand what @derberg means. @derberg Thank you for the feedback as well! |
Is the AsyncAPI CLI the same as the studio? |
@Annysah CLI is something that you use in the terminal -> https://www.asyncapi.com/tools/cli so for example after installing CLI, when you run |
So I was thinking in addition to creating a tutorial on how to get started with AsyncAPI using the CLI, we could also possibly restructure the outline of the "Getting Started" section. Here is a link to a draft of an outline idea I worked on: https://hashnode.com/preview/62cffe97466c6ad9ff5d96c2 cc: @alequetzalli @derberg @starlightknown @nelsonmic @pratik2315 @Florence-Njeri @thulieblack |
Oh lukaszzzz we especially wanted your thoughts on it! 😀 |
I have some concerns with the outline, basically what we lose, and we had so far:
I love to see tutorials will not only be about writing AsyncAPI document but also how to convert it into docs ❤️
|
It looks like we don't have sufficient reason to continue this one, so let's close this PR and leave our Quickstart as is. ✌🏽 |
Description
Related issue(s)
Fixes #793