Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of asserts allowing nulls #107

Closed
wants to merge 1 commit into from

Conversation

Muusssi
Copy link

@Muusssi Muusssi commented Sep 29, 2020

Mainly an idea for useful extension but not sure this is the best approach to implement these keywords.

Also having trouble with the acceptance tests that seem to fail for master as well and didn't yet have the time to understand what exactly is broken.

@asimell
Copy link
Contributor

asimell commented Apr 30, 2021

@Muusssi I don't see the benefit of writing a completely new keyword with practically identical contents. Instead of having 2 keywords, which call self._type_assertion with True and False you could just add an extra argument, like allow_null and give it a default value of False (as is the current behaviour).

Copy link
Contributor

This pull request is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 30, 2024
@asyrjasalo asyrjasalo closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants