Keep splash ending from input url #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is possible. Merging, crediting and releasing next RC to PyPI straight away. After some Googling, there is no single correct answer to this. Anyway, cannot think what this would break. There is a possibility that separate schemas will be generated, if both are used interchangeably in tests. Quite an easy fix to a seemingly rare case. |
asyrjasalo
added a commit
that referenced
this pull request
Dec 8, 2018
See: #52 Thanks Vinh Nguyen!
|
In my case that is Django project, I apply this library to testing API. |
|
Released: https://pypi.org/project/RESTinstance. Thank You! |
|
+1 to this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some in case API will be different with splash ending like that
/api/foo/and/api/foo. So that we should be keep original url from input.