Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip options validation when asking for version #81

Merged
merged 8 commits into from
Apr 9, 2021
Merged

Skip options validation when asking for version #81

merged 8 commits into from
Apr 9, 2021

Conversation

aduzsardi
Copy link
Contributor

If you think this is a reasonable fix for #79

@at-grandpa
Copy link
Owner

@aduzsardi
Thanks for the PR 🎉

I've added tests based on your suggestions and made the necessary corrections.
In addition, we found a new bug.
Thank you very much for your help. 👍

@at-grandpa at-grandpa merged commit c1f2111 into at-grandpa:master Apr 9, 2021
@aduzsardi
Copy link
Contributor Author

no problem , i should thank you for making this library available for others to use 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants