Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReconnectClient: fix chan handling on Disconnect #192

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

at-wat
Copy link
Owner

@at-wat at-wat commented Oct 15, 2021

No description provided.

@at-wat at-wat self-assigned this Oct 15, 2021
@at-wat at-wat marked this pull request as draft October 15, 2021 01:59
@at-wat at-wat changed the title Fix ReconnectClient task chan close timing ReconnectClient: fix chan handling on Disconnect Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #192 (606b7a0) into master (1763923) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   92.46%   92.45%   -0.01%     
==========================================
  Files          34       34              
  Lines        1831     1830       -1     
==========================================
- Hits         1693     1692       -1     
  Misses        118      118              
  Partials       20       20              
Impacted Files Coverage Δ
retryclient.go 91.07% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1763923...606b7a0. Read the comment docs.

@at-wat at-wat marked this pull request as ready for review October 15, 2021 03:06
@at-wat at-wat merged commit bc8af34 into master Oct 15, 2021
@at-wat at-wat deleted the fix-reconncli-chan-close-timing branch October 15, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant