Skip to content
This repository has been archived by the owner on Dec 29, 2019. It is now read-only.

[test] Use JUnit 5 #5

Closed
1 task done
at15 opened this issue Nov 1, 2017 · 3 comments
Closed
1 task done

[test] Use JUnit 5 #5

at15 opened this issue Nov 1, 2017 · 3 comments
Assignees
Milestone

Comments

@at15
Copy link
Owner

at15 commented Nov 1, 2017

@at15 at15 added this to the TAPL milestone Nov 1, 2017
@at15
Copy link
Owner Author

at15 commented Nov 2, 2017

it seems JUnit 5 can't generate report using gradle command https://github.com/junit-team/junit5-samples/tree/master/junit5-gradle-consumer

The results of any tests run via the JUnit Platform Gradle plugin will not be included in the standard test report generated by Gradle; however, the test results can typically be aggregated by your CI server software. See the reportsDir property of the plugin

@at15
Copy link
Owner Author

at15 commented Nov 2, 2017

and it mentioned container? not docker container .... I'm thinking too much

Two conditional extension points exist, ContainerExecutionCondition and TestExecutionCondition, and they can be used to deactivate either all tests in a container (likely a class) or individual tests (likely a test method).

from https://blog.codefx.org/libraries/junit-5-conditions/

at15 added a commit that referenced this issue Nov 2, 2017
- #2 added test helper for loading script from resource
- [ ] #2 need a custom parser error tracker
- #3 can parse the example script in the OCaml implementation w/o error
- #5 decide to use junit4 for now, we don't have much advanced use
case, just want to run test in IDEA directly
at15 added a commit that referenced this issue Nov 22, 2017
- didn't use any new feature, just copy from the example
https://github.com/junit-team/junit5-samples/tree/master/junit5-gradle-consumer
- the test report has different location (than gradle default),
but since we are not using any CI or test coverage tools, we ignore it for now
- TAPL is still using JUnit4, might switch to Junit5 when we start
implementing rest of TAPL
@at15 at15 modified the milestones: TAPL, 0.1 Nov 25, 2017
@at15 at15 self-assigned this Dec 8, 2017
@at15 at15 added the impl/java label Dec 8, 2017
@at15
Copy link
Owner Author

at15 commented Dec 8, 2017

I think I am still using it like JUnit4 ..... most advance features are not used, but anyway, it's running

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant