You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TimeF1 packets set to date_format 1 (w/ Month and Year available) are missing the month and day fields.
PR #31 introduced a new unit test test_time_bytes_with_ms that has a bug; it does not specify the date_format so the packet can only contain IRIG day, not the year. The year data is truncated, but this wasn't evident as the current year was re-added to the Python date time which at that time matched the test data so the bug wasn't revealed until the new year. Running the test now errors out with:
The test could be fixed by only comparing the fields that would be contained in date_format=0 packet (IRIG Day and below). A better fix would be TimeF1 with date_format=1 that includes the year data. Fixing that error than causes the test to error out with a new error:
TimeF1 packets set to date_format 1 (w/ Month and Year available) are missing the month and day fields.
PR #31 introduced a new unit test
test_time_bytes_with_ms
that has a bug; it does not specify the date_format so the packet can only contain IRIG day, not the year. The year data is truncated, but this wasn't evident as the current year was re-added to the Python date time which at that time matched the test data so the bug wasn't revealed until the new year. Running the test now errors out with:The test could be fixed by only comparing the fields that would be contained in date_format=0 packet (IRIG Day and below). A better fix would be TimeF1 with date_format=1 that includes the year data. Fixing that error than causes the test to error out with a new error:
In debugging this, a little restructuring of the unit test would reveal an unpack error due to not enough data.
PR incoming shortly.
The text was updated successfully, but these errors were encountered: