Fix TimeF1 ms decoding #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TimeF1 test that specifies a non-zero milliseconds to flex the encoding/decoding and ensure symmetry.
|
Good catch. Thanks for the PR! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the TimeF1 calculation of milliseconds from the component hundredths and tenths.
I opted to add a tiny new test that checks the encoding/decoding of a TimeF1 packet with non-zero milliseconds. Another option would be to modify the
sample.c10file to have a TimeF1 packet with a non-zero milliseconds, but this potentially involved modifying a lot of other trailing packets (and reverifying any tests that use the sample fixture).Drive-by: Fix minor issue with an AttributeError when manually creating an instance of a TimeF1 packet.
Fixes #30