-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added feature to allow users to select preferred styling lang #209
[Feature] Added feature to allow users to select preferred styling lang #209
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is Ready for Review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @naiknareshh for picking this up.
Review comments given.
If you could post some screenshots of your testing would be great.
Additionally, you need to update the CREATE PLAY Read me file to include this option and change the screenshot there. Please check https://github.com/atapas/react-play/blob/main/CREATE-PLAY.md#%EF%B8%8F-steps-to-create-a-play
efba61d
to
8479c97
Compare
Testing StepsStep 1: Validate 'Style to be used' question is queued up as expectedStep 2: Validate the files are getting created as expected and without any errors in the consoleStep 3: Validate proper import statement is added in the JSX fileStep 4: Add some styles to some existing elementStep 5: Validate the styles are reflected properly on the play without any issues |
@atapas All comments have been incorporated, please review and let me know if there is anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naiknareshh Looks good to me
@all-contributors please add @naiknareshh for Code |
I've put up a pull request to add @naiknareshh! 🎉 |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This feature allows user to select preferred styling language while creating the play. an empty 'css' or 'scss' file will be automatically added in their play directory based on the selection. No dependencies were added for this change.
Fixes #205
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: