-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shimmer effect #40
Shimmer effect #40
Conversation
…t-shimmer-effect.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/atapas/react-play/o8jWiBJgDQKTjA82PrfNTWBR9Sqv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just one change request. Can you please use yarn and commit the yarn lock file instead?
@abhikhatri67 Not sure if you got a chance to see this comment. |
@atapas Sure will do that. |
Done @atapas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@all-contributors please add @abhishek-gogroup for Code |
I've put up a pull request to add @abhishek-gogroup! 🎉 |
Description
Added shimmer effect in play thumbnails images using react-shimmer-effect npm package.
Type of change
How Has This Been Tested?
Tested this on a slow 3g network using chrome dev tools.
Checklist: