-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research options for handling duplicate files #4
Comments
Perhaps run a small built-in web server and serve up a thin web UI for managing the duplicates? This would almost necessitate creating/maintaining an in-memory state of the files as they're pruned/manged. |
StatusAfter working further with some photos, particularly trying to figure out where I left off on uploading files, I'm ready to push forward with this support. I think my earlier notes on this issue are still relevant; I think that pre-filling the column entries with Flag changesSome flag changes (based off of some scratch notes):
When processing a specified CSV input file, here are the requirements for each entry in the CSV file: Input CSV file requirements
|
Notes to self:
|
Other (unsorted) thoughts:
|
https://gobyexample.com/command-line-subcommands It's worth considering subcommands as a means of splitting application logic (somewhat) down the middle between two "modes" of operation:
Still need to give it some more thought, but these two subcommands seem like a decent starting point:
We can then tie specific flags to each of them. For example, having a |
Scratch notes for removal logic:
|
Re subcommand: stdlib covers this, but alexflint/go-arg does too and looks like it would be much easier to implement: |
- Split application logic (and flags) into subcommands - `report` for existing behavior and set of flags - `prune` for new behavior and new set of flags - Add support for pruning flagged/marked items in an input CSV file previously generated by the `report` subcommand - Documentation updates - README updates to cover both subcommands - CHANGELOG updates - GoDocs coverage of subcommands - GitHub Actions Workflow update to reflect cmd subdirectory - Makefile updates - new cmd subdirectory path - use "Simply expanded variables" (`:=`) vs those which are evaluated at each use (`=`) since we don't yet use that feature - Fix various linting errors refs #4
- Split application logic (and flags) into subcommands - `report` for existing behavior and set of flags - `prune` for new behavior and new set of flags - Add support for pruning flagged/marked items in an input CSV file previously generated by the `report` subcommand - Documentation updates - README updates to cover both subcommands - CHANGELOG updates - GoDocs coverage of subcommands - GitHub Actions Workflow update to reflect cmd subdirectory - Makefile updates - new cmd subdirectory path - use "Simply expanded variables" (`:=`) vs those which are evaluated at each use (`=`) since we don't yet use that feature - Fix various linting errors refs #4
- Split application logic (and flags) into subcommands - `report` for existing behavior and set of flags - `prune` for new behavior and new set of flags - Create subpackages for related chucks of code - e.g., `matches`, `paths`, ... - Add support for pruning flagged/marked items in an input CSV file previously generated by the `report` subcommand - Documentation updates - README updates to cover both subcommands - CHANGELOG updates - GoDocs coverage of subcommands - GitHub Actions Workflow update to reflect cmd subdirectory - Makefile updates - new cmd subdirectory path - use "Simply expanded variables" (`:=`) vs those which are evaluated at each use (`=`) since we don't yet use that feature - Fix various linting errors refs #4
- Split application logic (and flags) into subcommands - `report` for existing behavior and set of flags - `prune` for new behavior and new set of flags - Create subpackages for related chucks of code - e.g., `matches`, `paths`, ... - Add support for pruning flagged/marked items in an input CSV file previously generated by the `report` subcommand - Documentation updates - README updates to cover both subcommands - CHANGELOG updates - GoDocs coverage of subcommands - GitHub Actions Workflow update to reflect cmd subdirectory - Makefile updates - new cmd subdirectory path - use "Simply expanded variables" (`:=`) vs those which are evaluated at each use (`=`) since we don't yet use that feature - Fix various linting errors refs #4
Going to stick with the standard library for now. There are still some (many) lessons I can learn from implementing subcommand support using the |
From #1:
The initial v0.1 release will focus on creating a CSV file for manual review, but it would be useful to perform some sort of cleanup option either automatically or based on a column entry for the CSV file.
For example, the generated CSV file could create a column with prefilled "keep" action entries that the user could replace with
delete
. This could involve adding new flags:simulate
prune
The text was updated successfully, but these errors were encountered: