Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend metrics for check_vmware_datastore plugin #341

Closed
4 tasks done
atc0005 opened this issue Oct 1, 2021 · 1 comment · Fixed by #362
Closed
4 tasks done

Extend metrics for check_vmware_datastore plugin #341

atc0005 opened this issue Oct 1, 2021 · 1 comment · Fixed by #362
Assignees
@atc0005
Labels
datastore enhancement New feature or request output/perfdata Service Perf Data (aka, "performance data") refactor virtual machine
Milestone
v0.21.0

Comments

@atc0005
Copy link
Owner

atc0005 commented Oct 1, 2021 •
edited
Loading

The initial support for this plugin provided these metrics:

  • datastore_usage
  • datastore_storage_remaining

Some additional metrics that come to mind:

  • time (required for plugin to finish)
  • vms (not sure of wording)
  • vms_powered_on (not sure if this is helpful?)
  • vms_powered_off (is the contrast needed?)
@atc0005 atc0005 added enhancement New feature or request datastore output/perfdata Service Perf Data (aka, "performance data") labels Oct 1, 2021
@atc0005 atc0005 added this to the Next Release milestone Oct 1, 2021
@atc0005 atc0005 self-assigned this Oct 1, 2021
This was referenced Oct 2, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@atc0005
Copy link
Owner Author

atc0005 commented Oct 4, 2021 •
edited
Loading

Note to self: working on some light refactoring related to collecting summary details of VMs residing on a datastore. The plan is to use this work to make it easier to collect/report perfdata values.

I am considering doing this by folding the list of VMs (or at least a summary of them) into the DatastoreUsageSummary type.

atc0005 added a commit that referenced this issue Oct 5, 2021
@atc0005
Refactor datastore usage summary generation
46c37de 
- Pull out Virtual Machine datastore usage summary
  generation from the `LongServiceOutput` report into
  a separate `DatastoreVMsSummary()` function

- Rework `NewDatastoreUsageSummary()` function to bundle
  Virtual Machine summary details alongside datastore
  specific usage details

- Update `LongServiceOutput` report to reflect type
  changes

- Update main plugin code to drop generation of Virtual
  Machine collection, allowing the updated
 `NewDatastoreUsageSummary` function to handle that.

- Create new types and associated methods to collect
  Virtual Machine summary details for a specific
  Datastore.

This work is done in preparation for extending metrics
for the `check_vmware_datastore` plugin.

refs GH-341
atc0005 added a commit that referenced this issue Oct 5, 2021
@atc0005
Extend metrics for check_vmware_datastore plugin
c4a9d9a 
Add new metrics:

- `time` (plugin runtime)
- `vms` (total number of VMs found on datastore
- `vms_powered_on`
- `vms_powered_off`

refs GH-341
@atc0005 atc0005 mentioned this issue Oct 5, 2021
Closed
@atc0005 atc0005 mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
datastore enhancement New feature or request output/perfdata Service Perf Data (aka, "performance data") refactor virtual machine
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

Extend metrics for check_vmware_datastore plugin atc0005/check-vmware
1 participant
@atc0005