Replace use of deprecated toolsStatus field
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update functions which rely on this field to determine VMware Tools status to instead use the supported `toolsRunningStatus` and `toolsVersionStatus2` fields. Create helper function to consolidate evaluation logic and use it when filtering the initial VirtualMachine collection and later for determining the overall service state of the collection. Details included in the `LongServiceOutput` have also been updated to use the new field details and the stated threshold criteria have similarly been updated to reflect updated logic. refs GH-366
atc0005
added
tools
output/logging
virtual machine
output/extended
atc0005
changed the title
toolsStatus field
Replace coverage specific to the deprecated `toolsStatus` field with details for the `toolsVersionStatus2` and `toolsRunningStatus` fields. refs GH-366
atc0005
deleted the
i366-extend-vmware-tools-plugin-to-eval-additional-status-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update functions which rely on this field to determine VMware Tools
status to instead use the supported
toolsRunningStatusandtoolsVersionStatus2fields.Create helper function to consolidate evaluation logic and use it when
filtering the initial VirtualMachine collection and later for
determining the overall service state of the collection.
Details included in the
LongServiceOutputhave also been updated touse the new field details and the stated threshold criteria have
similarly been updated to reflect updated logic.
fixes GH-366