Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PerfData metrics to VMware Tools plugin #372

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add PerfData metrics to VMware Tools plugin #372

merged 1 commit into from
Oct 12, 2021

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Oct 8, 2021

  • Add Performance Data metrics
    • time
    • vms
    • vms_excluded_by_name
    • vms_excluded_by_power_state
    • vms_with_tools_issues
    • vms_without_tools_issues
    • resource_pools_excluded
    • resource_pools_included
    • resource_pools_evaluated
  • Extend structured logging fields to include Performance Data metrics

fixes GH-354

@atc0005 atc0005 added enhancement New feature or request tools virtual machine output/perfdata Service Perf Data (aka, "performance data") labels Oct 8, 2021
@atc0005 atc0005 added this to the Next Release milestone Oct 8, 2021
@atc0005 atc0005 self-assigned this Oct 8, 2021
@atc0005 atc0005 force-pushed the i354-add-perfdata-metrics-to-vmware-tools-plugin branch from 2cb6b86 to 9993ade Compare October 8, 2021 10:42
@atc0005 atc0005 marked this pull request as draft October 8, 2021 11:10
@atc0005
Copy link
Owner Author

atc0005 commented Oct 8, 2021

Found a logic problem with calculated perfdata metrics. Working on #373 which should make this easier to resolve for this plugin and further perfdata metrics work.

@atc0005 atc0005 force-pushed the i354-add-perfdata-metrics-to-vmware-tools-plugin branch from 9993ade to 2630cbe Compare October 12, 2021 12:03
@atc0005
Add PerfData metrics to VMware Tools plugin
1041e02 
- Add Performance Data metrics
  - `time`
  - `vms`
  - `vms_excluded_by_name`
  - `vms_excluded_by_power_state`
  - `vms_with_tools_issues`
  - `vms_without_tools_issues`
  - `resource_pools_excluded`
  - `resource_pools_included`
  - `resource_pools_evaluated`
- Extend structured logging fields to include Performance Data metrics

refs GH-354
@atc0005 atc0005 force-pushed the i354-add-perfdata-metrics-to-vmware-tools-plugin branch from 2630cbe to 1041e02 Compare October 12, 2021 12:12
@atc0005 atc0005 marked this pull request as ready for review October 12, 2021 12:14
@atc0005 atc0005 merged commit bce76b2 into master Oct 12, 2021
@atc0005 atc0005 deleted the i354-add-perfdata-metrics-to-vmware-tools-plugin branch October 12, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request output/perfdata Service Perf Data (aka, "performance data") tools virtual machine
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Add metrics for check_vmware_tools plugin
1 participant
@atc0005