Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply cmd directory structure #233

Closed
atc0005 opened this issue Apr 26, 2020 · 0 comments · Fixed by #241
Closed

Apply cmd directory structure #233

atc0005 opened this issue Apr 26, 2020 · 0 comments · Fixed by #241
Assignees
@atc0005
Labels
builds CI documentation Improvements or additions to documentation
Milestone
v0.7.4

Comments

@atc0005
Copy link
Owner

atc0005 commented Apr 26, 2020

As with other more recent Go projects I'm working on, I want to go ahead and convert this project to follow suit. For examples of converting existing layouts, see atc0005/send2teams#38, atc0005/send2teams#43.
@atc0005 atc0005 added documentation Improvements or additions to documentation builds CI labels Apr 26, 2020
@atc0005 atc0005 added this to the v0.7.4 milestone Apr 26, 2020
@atc0005 atc0005 self-assigned this Apr 26, 2020
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
03646dc 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - use same structure as other recent projects
  - use `-mod=vendor` to reflect Go 1.13 vendoring
  - replace two external shell scripts with equivalent
    embedded commands
  - Use automated Help menu

refs #189, #232, #233, #234
@atc0005 atc0005 mentioned this issue Apr 26, 2020
Merged
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
7f40bac 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - use same structure as other recent projects
  - use `-mod=vendor` to reflect Go 1.13 vendoring
  - replace two external shell scripts with equivalent
    embedded commands
  - Use automated Help menu

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
f126f7e 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for `atc0005/send2teams` project
  - generate binaries within `release_assets` subdirectory structure
  - dynamically determine go module path for version tag use
    - disabled for now as I have not moved this into a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go` commands to reflect Go 1.13 vendoring
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
918e7ea 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for `atc0005/send2teams` project
  - generate binaries within `release_assets` subdirectory structure
  - dynamically determine go module path for version tag use
    - disabled for now as I have not moved this into a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go` commands to reflect Go 1.13 vendoring
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
320cb0f 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for `atc0005/send2teams` project
  - generate binaries within `release_assets` subdirectory structure
  - dynamically determine go module path for version tag use
    - disabled for now as I have not moved this into a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go` commands to reflect Go 1.13 vendoring
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
fa4d76a 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for `atc0005/send2teams` project
  - generate binaries within `release_assets` subdirectory structure
  - dynamically determine go module path for version tag use
    - disabled for now as I have not moved this into a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go` commands to reflect Go 1.13 vendoring
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
4ffbb87 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for
    `atc0005/send2teams` project
  - generate binaries within `release_assets`
    subdirectory structure
  - dynamically determine go module path for version
    tag use
    - disabled for now as I have not moved this into
      a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go`
    commands to reflect Go 1.13 vendoring
    - this includes specifying `-mod=vendor` even for
      `go list` commands, which unless specified results
      in dependencies being donwloaded, even when they're
      alread provided in a local, top-level `vendor`
      directory
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
atc0005 added a commit that referenced this issue Apr 26, 2020
@atc0005
Restructure, update: cmd dir, Makefile, vendoring
8d7b224 
- Use `cmd/elbow` directory to match best practices

- Vendor dependencies

- Update Makefile
  - replace two external shell scripts with equivalent
    embedded commands
  - borrow heavily from existing `Makefile` for
    `atc0005/send2teams` project
  - generate binaries within `release_assets`
    subdirectory structure
  - dynamically determine go module path for version
    tag use
    - disabled for now as I have not moved this into
      a subpkg (e.g., `config`) yet
  - include `-mod=vendor` build flag for applicable `go`
    commands to reflect Go 1.13 vendoring
    - this includes specifying `-mod=vendor` even for
      `go list` commands, which unless specified results
      in dependencies being donwloaded, even when they're
      already provided in a local, top-level `vendor`
      directory
  - dynamic help/menu output based on recipe "doc comment"

- Update GitHub Actions Workflows
  - specify new cmd subdir path for builds
  - Disable running `go get` after checking out code
  - Exclude `vendor` folder from ...
    - Markdown linting checks
    - tests
    - basic build

- Update `.gitignore`
  - add ignored paths for binaries
  - add `release_assets`

- README
  - update one-off build examples to include new cmd subdirectory

refs #189, #232, #233, #234
@atc0005 atc0005 mentioned this issue Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
builds CI documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.7.4
Development

Successfully merging a pull request may close this issue.

Restructure, update: cmd dir, Makefile, vendoring atc0005/elbow
1 participant
@atc0005