Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for overridding section headers/labels #119

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Add support for overridding section headers/labels #119

merged 1 commit into from
Jun 15, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jun 15, 2022

Exported functionality:

  • add exported methods to set label text for Thresholds,
    Errors and Detailed Info sections

Unexported/helper functionality:

  • add unexported fields to track client code choices
  • add helper methods to provide client code choices or
    default values

fixes GH-107

@atc0005 atc0005 added enhancement New feature or request output/plugin plugin output intended for monitoring system ingest labels Jun 15, 2022
@atc0005 atc0005 added this to the Next Release milestone Jun 15, 2022
@atc0005 atc0005 self-assigned this Jun 15, 2022
@atc0005
Add support for overridding section headers/labels
68b1290 
Exported functionality:

- add exported methods to set label text for Thresholds,
  Errors and Detailed Info sections

Unexported/helper functionality:

- add unexported fields to track client code choices
- add helper methods to provide client code choices or
  default values

refs GH-107
@atc0005 atc0005 force-pushed the i107-add-support-for-overriding-section-headers branch from 0669aa0 to 68b1290 Compare June 15, 2022 12:46
@atc0005 atc0005 merged commit f0c9c49 into master Jun 15, 2022
@atc0005 atc0005 deleted the i107-add-support-for-overriding-section-headers branch June 15, 2022 12:48
atc0005 added a commit that referenced this pull request Jun 15, 2022
@atc0005
Fix incorrect interpolation order for labels
11c1af6 
Commit f0c9c49 applied an
incorrect interpolation order for the (potentially custom)
section header/label values.

This commit updates the order so that the label text is placed
within the formatting characters as intended.

refs GH-107
refs GH-119
@atc0005 atc0005 mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@atc0005 atc0005

Labels
enhancement New feature or request output/plugin plugin output intended for monitoring system ingest
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Add support for overriding section headers/labels
1 participant
@atc0005