BugFix: normalization by 0 in get_timelag_fromU0 #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lfarv, the macos-latest runs on the M1 chip and does not support python version < 3.10. Also matlab does not run on arm64 architecture. For the tests to complete I have changed the runner config such that macos-13 is used for python <3.10 and for the matlab tests |
lfarv
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
@swhite2401:
I could not find documentation about the changes GitHub made on macOS runners…
Anyway your solution looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #757
For multiple RF systems the synchronous phase is solved numerically. The system was normalized to U0 to prevent tolerance issues for the search of the stable point in the the presence of large energy loss per turn.
This normalization resulted in issue in get_timelag_fromU0 (called by findorbit6 and fastring) in the presence of multiple RF systems when radiations are off.
This issue is resolve by applying the normalization only when U0>0.