Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to CompletableFuture / HttpClient usage, misc changes #7

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Migrate to CompletableFuture / HttpClient usage, misc changes #7

merged 2 commits into from
Jun 15, 2023

Conversation

TheRealRyGuy
Copy link
Contributor

This is most absolutely breaking backwards compat, but I believe it's worth it
This migrates off of Java 8 fully, making use of Java 11's HttpClient (if you want to maintain Java 8 compat, easy enough to just use a different library)
Changes list

  • Adjusted all fields to be private, and where necessary, final
  • Remove redundant git submodules step from building
  • Migrated off of legacy Java http connections, making use of their Java HttpClient
  • All API based methods now are wrapped around a CompletableFuture, as they are all ran async
  • Made some misc changes

Fully aware that this would break every mclogs based plugin - more than happy to PR relevant changes if this is approved and implemented

@CLAassistant
Copy link

CLAassistant commented May 28, 2023

CLA assistant check
All committers have signed the CLA.

@TheRealRyGuy
Copy link
Contributor Author

Any update on this?

@JulianVennen
Copy link
Member

Hi, thanks for reminding me, I forgot about this PR.

I wanted to keep Java 8 support because old forge versions don't support newer Java versions, but supporting ancient Minecraft versions is annoying in many ways, so it's probably fine to drop them.

@JulianVennen JulianVennen merged commit 56e6744 into aternosorg:master Jun 15, 2023
@JulianVennen
Copy link
Member

Thank you for your contribution, 4.0.0 was released and will be on maven central as soon as sonatype syncs it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants