Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to publish raw data - fixes #3 #4

Merged
merged 4 commits into from
Feb 10, 2020
Merged

allow to publish raw data - fixes #3 #4

merged 4 commits into from
Feb 10, 2020

Conversation

dselivanov
Copy link
Contributor

No description provided.

atheriel
atheriel reviewed Feb 6, 2020
View reviewed changes
R/basic.R Outdated Show resolved Hide resolved
atheriel
atheriel reviewed Feb 6, 2020
View reviewed changes
R/basic.R Outdated Show resolved Hide resolved
atheriel
atheriel reviewed Feb 6, 2020
View reviewed changes
R/basic.R Outdated Show resolved Hide resolved
atheriel
atheriel reviewed Feb 6, 2020
View reviewed changes
R/basic.R Outdated Show resolved Hide resolved
atheriel
atheriel reviewed Feb 6, 2020
View reviewed changes
R/basic.R Outdated Show resolved Hide resolved
@atheriel
Copy link
Owner

atheriel commented Feb 6, 2020

I thought I had implemented this already, definitely an error on my part. Thanks for the submission.

@atheriel atheriel added the enhancement New feature or request label Feb 6, 2020
@dselivanov
Copy link
Contributor Author

@atheriel thanks for valuable comments

@dselivanov
Copy link
Contributor Author

However now I think library should produce error, not a warning when the character body length is not equal to one. For interactive use warning would be 'okay'. But for non-interactive use it is better to fail fast rather than spending a lot of time on debug later (I believe in most of the cases this package will be used in non-interactive mode)

atheriel
atheriel reviewed Feb 8, 2020
View reviewed changes
man/amqp_publish.Rd Outdated Show resolved Hide resolved
@atheriel atheriel merged commit fa11699 into atheriel:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheriel atheriel atheriel left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dselivanov @atheriel