-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group prometheus metrics #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ removed not working metrics from MetricsHttpClientWrapper.cs
CptnSnail
reviewed
Feb 22, 2024
CptnSnail
reviewed
Feb 22, 2024
…e by default Can be overriden through DataBaseOptions
CptnSnail
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MetricsServiceName
andsummaryName
(class name) from metric's name, also removedMetricsServiceName
fromMetricsOptions
common_metric_
MetricsHtttpClientWrapper
MetricsHtttpClientWrapper
, it didn't worked;adding metrics to
MetricsHtttpClientWrapper
requires passing urlTemplate, serviceName and possibility to disable them, otherwise it duplicates metrics fromConsulMetricsHttpClientWrapper
AddAtiMetrics
- alias forAddMetrics
, cause this one conflicts withMicrosoft.Extensions.DependencyInjection.MetricsServiceExtensions.AddMetrics
starting .net7X-Client-Name
headerComparison with previous
For example previous http metrics:
default_nameXzibitServiceAdapter{}
default_nameAuthorizationAdapter{}
default_nameMarshakAdapter{}
and so onBecame one metric:
common_metric_http_client{__name__ = "class_name_here"}
New metrics list