Big cleanup in the join logic and addition of big tests #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because cloned models are not very reliable now.
Applied fixes from StyleCI
Applied fixes from StyleCI
Applied fixes from StyleCI
…stence because persistence may be asked to save some of those fields by Join.
no need for each persistence to duplicate this.
Applied fixes from StyleCI
…o feature/major-join-cleanup
| foreach ($this->elements as $id => $el) { | ||
| if ($el instanceof Join) { | ||
| $this->elements[$id] = clone $el; | ||
| $el->owner = $this; |
There was a problem hiding this comment.
I guess there is bug. $el variable will be lost after foreach anyway. Probably $this->elements[$id]->owner should be there instead of $el->owner.
There was a problem hiding this comment.
strangely - changing this logic breaks the build.
This was referenced Aug 25, 2016
|
|
||
| ### Introducing Actions | ||
|
|
||
| ORM/Active Record is not designed for relational databases. There are too much potential that ORM |
There was a problem hiding this comment.
should be "... is not only designed ..." instead of "... is not designed ..." otherwise reader will think that AD will not work for SQL bases at all :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces few necessary tools to run more sophisticated tests and then fixes a few issues that were spotted when using Agile Data in commercial projects.
SMBO TestSuite
SMBO is an accounting app. A few models have been mocked up with the similar logic and presented in tests/smbo/lib. Test scripts use those models to test a deeper logic.
Added TransferTest
In SMBO there is an entity called Document. Any document with doc_type='payment' is considered Payment. Some of those payments can be Transfers.
Transfers exist in pairs - one transfer decrease amount on source account, the other transfer increases the amount on the destination account.
Creating a transfer will create the other leg too and cross-link those documents.
Implementing Cloning support.
When transfer document is created and we are willing to create a destination record, it is actually mirror-matched to our own record. Although we could copy all the properties, some users may want to do a "clone" here.
I have improved support for model cloning. The new clone must have no associations with the source model. Previously something wasn't linking up correctly, so when creating a transfer, some ID values were shared incorrectly.
Join refactoring
Previously joins were linked between 2 physical fields. When creating a join they were updating "insert" query of the parent to add the field in there.
Now joins are refactored in a way where they are joined between a Model field and a physical field of joined table. So in theory you should be able to:
Instead of beforeInsertQuery it now uses beforeInsert and same thing with modification.