-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of set/get #21
Conversation
I've finished with this PR, so it's fully ready for review and merge. Working on "Persisting" next. |
@@ -14,7 +14,8 @@ | |||
], | |||
"require": { | |||
"php": ">=5.5.0", | |||
"atk4/dsql": "*" | |||
"atk4/dsql": "*", | |||
"atk4/core": "1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need atk core in agile data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we're using implementation for hooks, containers and initializers:
Seems good to me, except the 2 comments |
I'm ticking off the check-lists above, @skondakov |
This PR implements:
functionality of the basic Active Record pattern. While the loading of an active record is not supported yet, you can work with the values already.
For reviewer, please check: