Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of set/get #21

Merged
merged 10 commits into from
Jun 23, 2016
Merged

Implementation of set/get #21

merged 10 commits into from
Jun 23, 2016

Conversation

romaninsh
Copy link
Member

@romaninsh romaninsh commented May 28, 2016

This PR implements:

$m['foo'] = 123;

functionality of the basic Active Record pattern. While the loading of an active record is not supported yet, you can work with the values already.

For reviewer, please check:

  • Code looks OK
  • Test scripts present
  • Well-documented
  • No outstanding questions or issues or TODO items

@romaninsh
Copy link
Member Author

I've finished with this PR, so it's fully ready for review and merge. Working on "Persisting" next.

@romaninsh romaninsh mentioned this pull request Jun 10, 2016
8 tasks
@@ -14,7 +14,8 @@
],
"require": {
"php": ">=5.5.0",
"atk4/dsql": "*"
"atk4/dsql": "*",
"atk4/core": "1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need atk core in agile data?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we're using implementation for hooks, containers and initializers:

http://agile-core.readthedocs.io/en/latest/

@skondakov
Copy link
Contributor

Seems good to me, except the 2 comments

@romaninsh
Copy link
Member Author

I'm ticking off the check-lists above, @skondakov

@romaninsh romaninsh merged commit 7a836e5 into develop Jun 23, 2016
@romaninsh romaninsh deleted the feature/bm-1-add-field branch July 15, 2016 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants