Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit ID have default type of integer and is required by default #806

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Implicit ID have default type of integer and is required by default #806

merged 3 commits into from
Dec 11, 2020

Conversation

mvorisek
Copy link
Member

slightly a BC break, but not in standard cases

@mvorisek mvorisek changed the title Implicit ID have default type of integer Implicit ID have default type of integer and is required by default Dec 11, 2020
georgehristov
georgehristov approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd support this

@mvorisek mvorisek merged commit 67a42e5 into develop Dec 11, 2020
@mvorisek mvorisek deleted the default_id_integer branch December 11, 2020 22:12
This was referenced Dec 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov