Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup values are not loaded when callbacks are in a particular order #1587

Closed
acicovic opened this issue Jan 8, 2021 · 2 comments
Closed

Lookup values are not loaded when callbacks are in a particular order #1587

acicovic opened this issue Jan 8, 2021 · 2 comments
Assignees
@ibelar
Labels
bug 🪲

Comments

@acicovic
Copy link
Collaborator

acicovic commented Jan 8, 2021

See https://github.com/acicovic/atk4-lookup-test
ibelar added a commit that referenced this issue Feb 1, 2021
@ibelar
[fix] VirtualPage
b01abf6 
Fix for #1587

Callable for VirtualPage should be called prior to VirtualPage::getHtml() in order to make sure nested callback (Lookup) can be reach.
@ibelar ibelar mentioned this issue Feb 1, 2021
Merged
@ibelar
Copy link
Contributor

ibelar commented Feb 1, 2021

@acicovic - Thanks for supplying code for this bug.

ibelar added a commit that referenced this issue Feb 3, 2021
@ibelar
[fix] VirtualPage (#1602)
32f18d7 
* [fix] VirtualPage

Fix for #1587

Callable for VirtualPage should be called prior to VirtualPage::getHtml() in order to make sure nested callback (Lookup) can be reach.

* cs fix

* phpstan

* fix test

* more fix

* Add behat test

* fix typo

* phpstan

* phpstan

* fix typo

* fixes

* fix test

* phpstan
@ibelar
Copy link
Contributor

ibelar commented Feb 3, 2021

fix in #1602

@ibelar ibelar closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibelar ibelar

Labels
bug 🪲
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibelar @acicovic