Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualPage/Callback don't catch exceptions #234

Closed
DarkSide666 opened this issue Oct 13, 2017 · 2 comments
Closed

VirtualPage/Callback don't catch exceptions #234

DarkSide666 opened this issue Oct 13, 2017 · 2 comments
Assignees
@ob6160 @ibelar
Labels
help wanted JS

Comments

@DarkSide666
Copy link
Member

VirtualPage and/or Callback should catch all exceptions and pass them back to user browser nicely in JSON.
Otherwise we get empty modal dialog in browser and see exception text only in server response as HTTML.

untitled
@romaninsh
Copy link
Member

@ibelar @ob6160 can one of you look into this?

@romaninsh
Copy link
Member

We could make this pop-up say that URL $x did not return expected content.

romaninsh added a commit that referenced this issue Oct 16, 2017
@romaninsh
Add loader demo which triggers #234 error
144d8a6
@romaninsh romaninsh mentioned this issue Oct 16, 2017
Merged
romaninsh added a commit that referenced this issue Oct 16, 2017
@romaninsh
Merge pull request #238 from atk4/feature/issue-234
2a21208 
Add loader demo which triggers #234 error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ob6160 ob6160

@ibelar ibelar

Labels
help wanted JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@romaninsh @ob6160 @DarkSide666 @ibelar