Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #1087

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Documentation updates #1087

merged 3 commits into from
Apr 13, 2020

Conversation

TheNetworkIsDown
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #1087 into develop will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1087      +/-   ##
=============================================
+ Coverage      71.42%   72.83%   +1.41%     
+ Complexity      2663     2623      -40     
=============================================
  Files            126      125       -1     
  Lines           6254     6159      -95     
=============================================
+ Hits            4467     4486      +19     
+ Misses          1787     1673     -114     
Impacted Files Coverage Δ Complexity Δ
src/ActionExecutor/ArgumentForm.php 76.47% <0.00%> (-9.25%) 6.00% <0.00%> (+1.00%) ⬇️
src/VirtualPage.php 68.88% <0.00%> (-6.67%) 18.00% <0.00%> (ø%)
src/FormField/Lookup.php 58.39% <0.00%> (-4.45%) 54.00% <0.00%> (-2.00%)
src/CardSection.php 89.28% <0.00%> (-3.58%) 12.00% <0.00%> (ø%)
src/FormField/Upload.php 57.97% <0.00%> (-1.74%) 36.00% <0.00%> (+1.00%) ⬇️
src/Form.php 77.43% <0.00%> (-0.61%) 68.00% <0.00%> (ø%)
src/Card.php 69.91% <0.00%> (-0.33%) 60.00% <0.00%> (+1.00%) ⬇️
src/jsSSE.php 94.54% <0.00%> (-0.29%) 21.00% <0.00%> (-2.00%)
src/ActionExecutor/UserAction.php 41.69% <0.00%> (-0.23%) 103.00% <0.00%> (+3.00%) ⬇️
src/Grid.php 60.10% <0.00%> (-0.21%) 80.00% <0.00%> (ø%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f12bac...8ef845f. Read the comment docs.

@TheNetworkIsDown
Copy link
Contributor Author

Oh BTW I have noticed that on agile-ui.readthedocs.io, the "develop" branch is not available for consultation, whereas on agile-data.readthedocs.io it is.

@TheNetworkIsDown TheNetworkIsDown changed the title Doc: Form: Explain setInputAttr plus some minor layout fixes Documentation updates Apr 13, 2020
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@DarkSide666 DarkSide666 merged commit cc8bfd7 into atk4:develop Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants