Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Behat js Callback test #1096

Merged
merged 4 commits into from
Apr 15, 2020
Merged

[fix] Behat js Callback test #1096

merged 4 commits into from
Apr 15, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Apr 15, 2020

Fixes for #1092

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1096 into develop will not change coverage.
The diff coverage is 94.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1096   +/-   ##
==========================================
  Coverage      75.96%   75.96%           
  Complexity      2653     2653           
==========================================
  Files            128      128           
  Lines           6242     6242           
==========================================
  Hits            4742     4742           
  Misses          1500     1500           
Impacted Files Coverage Δ Complexity Δ
src/Layout/Generic.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/TableColumn/FilterModel/TypeDate.php 0.00% <0.00%> (ø) 14.00 <1.00> (ø)
src/TableColumn/FilterModel/TypeDatetime.php 0.00% <0.00%> (ø) 22.00 <1.00> (ø)
src/TableColumn/FilterModel/TypeEnum.php 0.00% <0.00%> (ø) 9.00 <5.00> (ø)
src/TableColumn/FilterModel/TypeTime.php 0.00% <0.00%> (ø) 6.00 <1.00> (ø)
src/ActionExecutor/UserAction.php 82.65% <100.00%> (ø) 103.00 <1.00> (ø)
src/ActionExecutor/UserConfirmation.php 93.58% <100.00%> (ø) 25.00 <1.00> (ø)
src/App.php 83.00% <100.00%> (ø) 146.00 <3.00> (ø)
src/CRUD.php 57.69% <100.00%> (ø) 62.00 <3.00> (ø)
src/Callback.php 97.22% <100.00%> (ø) 13.00 <5.00> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fc859...600346b. Read the comment docs.

@mvorisek mvorisek merged commit c9db1f8 into develop Apr 15, 2020
@mvorisek mvorisek deleted the fix/behat-js-text branch April 15, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants