Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade phpunit #1101

Merged
merged 14 commits into from
Apr 20, 2020
Merged

Upgrade phpunit #1101

merged 14 commits into from
Apr 20, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 15, 2020 •
edited
Loading

No description provided.

@mvorisek mvorisek marked this pull request as draft April 15, 2020 18:00
@mvorisek mvorisek closed this Apr 15, 2020
@mvorisek mvorisek reopened this Apr 15, 2020
@codecov
Copy link

codecov bot commented Apr 15, 2020 •
edited
Loading

Codecov Report

Merging #1101 into develop will decrease coverage by 50.68%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #1101       +/-   ##
==============================================
- Coverage      75.61%   24.92%   -50.69%     
+ Complexity      2659     2524      -135     
==============================================
  Files            128      128               
  Lines           6253     6195       -58     
==============================================
- Hits            4728     1544     -3184     
- Misses          1525     4651     +3126
Impacted Files Coverage Δ Complexity Δ
src/Tab.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
src/Item.php 0.00% <0.00%> (-100.00%) 3.00% <0.00%> (ø%)
src/Header.php 0.00% <0.00%> (-100.00%) 12.00% <0.00%> (ø%)
src/Columns.php 0.00% <0.00%> (-100.00%) 10.00% <0.00%> (ø%)
src/jsReload.php 0.00% <0.00%> (-100.00%) 6.00% <0.00%> (ø%)
src/GridLayout.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
src/HelloWorld.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/LoremIpsum.php 0.00% <0.00%> (-100.00%) 8.00% <0.00%> (ø%)
src/ProgressBar.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
src/TabsSubView.php 0.00% <0.00%> (-100.00%) 2.00% <0.00%> (ø%)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1664397...59f1eba. Read the comment docs.

@mvorisek
Copy link
Member Author

Help wanted for the failing tests.

@mvorisek mvorisek marked this pull request as ready for review April 20, 2020 08:10
@mvorisek
Copy link
Member Author

@abbadon1334 Thanks, great work!

@DarkSide666 DarkSide666 self-requested a review April 20, 2020 09:56
DarkSide666
DarkSide666 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DarkSide666 DarkSide666 merged commit d14a6f4 into atk4:develop Apr 20, 2020
@mvorisek mvorisek deleted the upgrade_phpunit branch April 20, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @DarkSide666 @abbadon1334