Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Maestro Layout #1120

Merged
merged 26 commits into from
Apr 24, 2020
Merged

[feature] Maestro Layout #1120

merged 26 commits into from
Apr 24, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Apr 21, 2020

A new layout based on the admin layout with improve left menu.

  • Indicate which group and page you are in;
  • Collapsable group;
  • Clicking on a group title will bring you to the first menu item in the group;
  • Proper group open on page load

Note

Require atkjs-ui.min.js v1.14.0
Change default admin for demos to use Maestro.

Screen Shot 2020-04-21 at 3 52 05 PM

Screen Shot 2020-04-21 at 3 52 26 PM

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #1120 into develop will increase coverage by 0.23%.
The diff coverage is 88.88%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1120      +/-   ##
=============================================
+ Coverage      75.61%   75.85%   +0.23%     
- Complexity      2659     2765     +106     
=============================================
  Files            128      130       +2     
  Lines           6253     6381     +128     
=============================================
+ Hits            4728     4840     +112     
- Misses          1525     1541      +16     
Impacted Files Coverage Δ Complexity Δ
src/Layout/Admin.php 89.65% <75.00%> (-6.00%) 11.00 <3.00> (+3.00) ⬇️
src/Layout/Maestro.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Menu.php 90.90% <100.00%> (ø) 25.00 <3.00> (ø)
src/CardDeck.php 66.66% <0.00%> (-0.40%) 89.00% <0.00%> (+4.00%) ⬇️
src/Locale.php 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/Panel/Content.php 100.00% <0.00%> (ø) 8.00% <0.00%> (+2.00%)
src/ActionExecutor/jsEvent.php 0.00% <0.00%> (ø) 32.00% <0.00%> (+9.00%)
src/ActionExecutor/jsArgumentForm.php 0.00% <0.00%> (ø) 20.00% <0.00%> (+8.00%)
src/TableColumn/HTML.php 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1664397...773627d. Read the comment docs.

@ibelar ibelar requested a review from DarkSide666 April 22, 2020 23:42
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

js/src/plugins/admin-menu.plugin.js Outdated Show resolved Hide resolved
js/src/plugins/sidenav.plugin.js Outdated Show resolved Hide resolved
@ibelar ibelar merged commit 98b08c7 into develop Apr 24, 2020
@ibelar ibelar deleted the feature/admin-menu-2 branch April 24, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants