Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Remove Footer Height Rule #1131

Merged
merged 1 commit into from
Apr 25, 2020
Merged

[fix] Remove Footer Height Rule #1131

merged 1 commit into from
Apr 25, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Apr 24, 2020

Fix: #1129

@codecov
Copy link

codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #1131 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1131   +/-   ##
==========================================
  Coverage      75.66%   75.66%           
  Complexity      2536     2536           
==========================================
  Files            130      130           
  Lines           6225     6225           
==========================================
  Hits            4710     4710           
  Misses          1515     1515

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b08c7...4c20d7e. Read the comment docs.

DarkSide666
DarkSide666 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit ee69b3e into develop Apr 25, 2020
@mvorisek mvorisek deleted the fix/remove-unused-footer-height branch April 25, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin layout with wrong footer stickyness
3 participants
@ibelar @DarkSide666 @mvorisek