-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] - Header Menu Size #1151
[fix] - Header Menu Size #1151
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1151 +/- ##
=============================================
+ Coverage 75.77% 75.96% +0.18%
- Complexity 2538 2539 +1
=============================================
Files 130 130
Lines 6230 6287 +57
=============================================
+ Hits 4721 4776 +55
- Misses 1509 1511 +2
Continue to review full report at Codecov.
|
Fix #1156 |
Added my CSS rules to that issue, see. And add "fix #nn" text always to the issue description, otherwise it does not work, ie. the issue will be not closed otherwise. |
@@ -101,7 +101,7 @@ footer.atk-footer .ui.segment { | |||
margin: 0; | |||
} | |||
.ui.left.sidebar { | |||
z-index: 103; | |||
z-index: 99; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fix to #1156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this should fix on #1156, as it does not solved it it should be probably reverted.
But otherwise PR is read to be merged
@@ -101,7 +101,7 @@ footer.atk-footer .ui.segment { | |||
margin: 0; | |||
} | |||
.ui.left.sidebar { | |||
z-index: 103; | |||
z-index: 99; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this should fix on #1156, as it does not solved it it should be probably reverted.
But otherwise PR is read to be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes issue for me, so LGTM
@DarkSide666 because I fixed it :) |
Thank you! :) |
Are you pulling css locally or via jsDeliver? If from jsDeliver, then give it a day at least to be updates correctly. |
PR #1168 for faster collaboration ? @mkrecek234 does this help? PS using old Admin, Maestro might need more work, please double check/fix my commits if needed. |
@mkrecek234 Great, thank you for your fbk. This PR should have no affect on the horizontal/top panel excep the updated height. |
Make sure there is no gap between the top and navigation menu.
fix #1156