Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Table link column with model using Date field #1186

Merged
merged 2 commits into from
May 14, 2020
Merged

[fix] Table link column with model using Date field #1186

merged 2 commits into from
May 14, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented May 12, 2020

Quick fixe for #1184

@ibelar ibelar requested a review from DarkSide666 May 12, 2020 16:31
@codecov
Copy link

codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #1186 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1186   +/-   ##
==========================================
  Coverage      72.75%   72.75%           
- Complexity      2544     2545    +1     
==========================================
  Files            130      130           
  Lines           6236     6237    +1     
==========================================
+ Hits            4537     4538    +1     
  Misses          1699     1699
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Link.php 90.90% <100.00%> (+0.21%) 26.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959c5f2...b17d1c7. Read the comment docs.

@ibelar ibelar mentioned this pull request May 13, 2020
Merged
DarkSide666
DarkSide666 approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now.

@DarkSide666 DarkSide666 merged commit 371d091 into develop May 14, 2020
@DarkSide666 DarkSide666 deleted the fix/talble-link-column branch May 14, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibelar @DarkSide666