Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Throwable instead of Exception #1193

Merged
merged 2 commits into from
May 15, 2020
Merged

Catch Throwable instead of Exception #1193

merged 2 commits into from
May 15, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented May 15, 2020

fix #921

@mvorisek mvorisek marked this pull request as ready for review May 15, 2020 10:05
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #1193 into develop will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1193   +/-   ##
==========================================
  Coverage      72.77%   72.77%           
  Complexity      2548     2548           
==========================================
  Files            130      130           
  Lines           6248     6248           
==========================================
  Hits            4547     4547           
  Misses          1701     1701           
Impacted Files Coverage Δ Complexity Δ
src/ActionExecutor/UserAction.php 42.16% <0.00%> (ø) 95.00 <0.00> (ø)
src/jsCallback.php 72.97% <0.00%> (ø) 27.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9468d5...1ad2968. Read the comment docs.

Copy link
Collaborator

@abbadon1334 abbadon1334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i rerun the check, probably something is still wrong in actions it fails random

@mvorisek
Copy link
Member Author

@abbadon1334 issue is with CS as pointed by @ibelar , see #1190 (comment) , introduced by a PR merged/created before the CS rules were added.

@abbadon1334
Copy link
Collaborator

@abbadon1334 issue is with CS as pointed by @ibelar , see #1190 (comment) , introduced by a PR merged/created before the CS rules were added.

i see : https://github.com/atk4/ui/pull/1193/checks?check_run_id=677694450#step:13:26

@DarkSide666 DarkSide666 merged commit 2860ae2 into develop May 15, 2020
@DarkSide666 DarkSide666 deleted the mvorisek-patch-2 branch May 15, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Important: Call to undefined method PDOException::getHTML()
3 participants