Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up after #1177 #1203

Merged
merged 3 commits into from
May 18, 2020
Merged

clean up after #1177 #1203

merged 3 commits into from
May 18, 2020

Conversation

romaninsh
Copy link
Member

fix travis after I accidentally merged #1177 without doing the fix in the corresponding branch

@mvorisek
Copy link
Member

accidentally

ok, no need to approve this

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #1203 into develop will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1203      +/-   ##
=============================================
- Coverage      72.75%   72.66%   -0.10%     
- Complexity      2544     2547       +3     
=============================================
  Files            130      130              
  Lines           6237     6248      +11     
=============================================
+ Hits            4538     4540       +2     
- Misses          1699     1708       +9     
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Multiformat.php 75.67% <0.00%> (-18.92%) 12.00% <0.00%> (ø%)
src/VirtualPage.php 68.62% <0.00%> (-0.27%) 21.00% <0.00%> (+3.00%) ⬇️
src/CardDeck.php 66.25% <0.00%> (-0.21%) 80.00% <0.00%> (ø%)
src/Form.php 67.85% <0.00%> (ø) 62.00% <0.00%> (ø%)
src/FormField/Lookup.php 58.95% <0.00%> (ø) 49.00% <0.00%> (ø%)
src/TableColumn/HTML.php 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/TableColumn/Money.php 86.66% <0.00%> (ø) 7.00% <0.00%> (ø%)
src/TableColumn/Status.php 82.35% <0.00%> (ø) 12.00% <0.00%> (ø%)
src/FormField/MultiLine.php 37.17% <0.00%> (ø) 127.00% <0.00%> (-1.00%)
src/TableColumn/Generic.php 84.53% <0.00%> (ø) 37.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 160be0e...80e68a5. Read the comment docs.

@mvorisek
Copy link
Member

@romaninsh very low quality PR

@mvorisek mvorisek merged commit 018ab7a into develop May 18, 2020
@mvorisek mvorisek deleted the mvorisek-patch-1 branch May 18, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants