Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Left menu visibility #1217

Merged
merged 2 commits into from
May 30, 2020
Merged

[fix] Left menu visibility #1217

merged 2 commits into from
May 30, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented May 30, 2020

Set visibility server-side instead of via javascript

  • prevent menu flickering.

Set visibility server side instead of via javascript
- prevent menu flickering.
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #1217 into develop will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1217      +/-   ##
=============================================
- Coverage      72.69%   72.68%   -0.02%     
  Complexity      2546     2546              
=============================================
  Files            130      130              
  Lines           6245     6245              
=============================================
- Hits            4540     4539       -1     
- Misses          1705     1706       +1     
Impacted Files Coverage Δ Complexity Δ
src/FormField/MultiLine.php 37.54% <0.00%> (ø) 126.00 <0.00> (ø)
src/Layout/Admin.php 86.20% <50.00%> (-3.45%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede179e...0c1c108. Read the comment docs.

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@DarkSide666 DarkSide666 merged commit 56e414a into develop May 30, 2020
@DarkSide666 DarkSide666 deleted the fix/left-menu-visibility branch May 30, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants