Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect unwanted output before App::outputResponse() #1220

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Detect unwanted output before App::outputResponse() #1220

merged 6 commits into from
Jun 2, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 2, 2020 •
edited
Loading

Until now it was detected only if the output was >= than output_buffering php.ini threshold and thus already detected by headers_sent() few lines below

no BC break for normal code

@mvorisek mvorisek requested a review from DarkSide666 June 2, 2020 08:52
@mvorisek mvorisek marked this pull request as draft June 2, 2020 09:17
@mvorisek mvorisek marked this pull request as ready for review June 2, 2020 09:25
@mvorisek mvorisek mentioned this pull request Jun 2, 2020
Merged
DarkSide666
DarkSide666 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 06d37a6 into atk4:develop Jun 2, 2020
@mvorisek mvorisek deleted the check_unflushed_output branch June 4, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666