Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Fomantic UI 2.8.5 #1240

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jun 4, 2020

Update to Fomantic 2.8.5

  • Add the possibility to set Fomantic-UI tab settings when adding them.

fixes #992
fixes #1044

Example when you need to pass an argument for the callback:

$t->addTab('Dynamic Lorem Ipsum', function ($tab) {
    \atk4\ui\Message::addTo($tab, ['Every time you come to this tab, you will see a different text']);
    \atk4\ui\LoremIpsum::addTo($tab, ['size' => (int) $_GET['size'] ?? 1]);
}, ['apiSettings' => ['data' => ['size' => random_int(1, 4)]]]);

@ibelar ibelar marked this pull request as draft June 4, 2020 20:16
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #1240 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1240      +/-   ##
=============================================
+ Coverage      72.83%   72.85%   +0.01%     
- Complexity      2557     2558       +1     
=============================================
  Files            130      130              
  Lines           6270     6274       +4     
=============================================
+ Hits            4567     4571       +4     
  Misses          1703     1703              
Impacted Files Coverage Δ Complexity Δ
src/App.php 82.16% <ø> (ø) 147.00 <0.00> (ø)
src/FormLayout/Section/Tabs.php 100.00% <100.00%> (ø) 1.00 <1.00> (ø)
src/Tab.php 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
src/Tabs.php 89.65% <100.00%> (ø) 9.00 <6.00> (ø)
src/jsToast.php 75.00% <100.00%> (+5.00%) 7.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59506b...d20a46a. Read the comment docs.

@ibelar ibelar marked this pull request as ready for review June 5, 2020 13:01
@ibelar ibelar requested a review from mvorisek June 5, 2020 13:02
@mvorisek mvorisek removed their request for review June 5, 2020 13:03
@mvorisek
Copy link
Member

mvorisek commented Jun 5, 2020

@ibelar RTM from me, I can not tell if it breaks something or not

@mvorisek mvorisek added the RTM label Jun 5, 2020
@ibelar
Copy link
Contributor Author

ibelar commented Jun 5, 2020

@ibelar RTM from me, I can not tell if it breaks something or not

I should be ok, i.e. no BC Break. What does RTM mean?

@mvorisek
Copy link
Member

mvorisek commented Jun 5, 2020

RTM means ReadyToMerge. You can merge it immediatelly.

@mvorisek mvorisek changed the title feature - Update to Fomantic UI 2.8.5 Upgrade to Fomantic UI 2.8.5 Jun 5, 2020
@mvorisek mvorisek removed their request for review June 6, 2020 15:23
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 19e31a1 into develop Jun 6, 2020
@DarkSide666 DarkSide666 deleted the feature/update-to-fomatic-2-8-5 branch June 6, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs with wrong default active tab Improve UX - Add arrow to all/between Wizard items
3 participants