-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Fomantic UI 2.8.5 #1240
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1240 +/- ##
=============================================
+ Coverage 72.83% 72.85% +0.01%
- Complexity 2557 2558 +1
=============================================
Files 130 130
Lines 6270 6274 +4
=============================================
+ Hits 4567 4571 +4
Misses 1703 1703
Continue to review full report at Codecov.
|
@ibelar RTM from me, I can not tell if it breaks something or not |
I should be ok, i.e. no BC Break. What does RTM mean? |
RTM means ReadyToMerge. You can merge it immediatelly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update to Fomantic 2.8.5
fixes #992
fixes #1044
Example when you need to pass an argument for the callback: