Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exception constructor calls to not use array #1242

Merged
merged 11 commits into from
Jun 6, 2020
Merged

Refactor exception constructor calls to not use array #1242

merged 11 commits into from
Jun 6, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 5, 2020

refactor for: atk4/core#223

this PR itself is pure refacotirng without any functionality change thus 100% BC

@mvorisek mvorisek marked this pull request as ready for review June 5, 2020 20:42
@mvorisek mvorisek added the RTM label Jun 5, 2020
@DarkSide666 DarkSide666 self-requested a review June 6, 2020 12:49
@atk4 atk4 deleted a comment from codecov bot Jun 6, 2020
@codecov
Copy link

codecov bot commented Jun 6, 2020

Codecov Report

Merging #1242 into develop will decrease coverage by 0.49%.
The diff coverage is 11.56%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1242      +/-   ##
=============================================
- Coverage      72.83%   72.34%   -0.50%     
  Complexity      2557     2557              
=============================================
  Files            130      130              
  Lines           6270     6313      +43     
=============================================
  Hits            4567     4567              
- Misses          1703     1746      +43     
Impacted Files Coverage Δ Complexity Δ
src/ActionExecutor/ArgumentForm.php 70.58% <0.00%> (-4.42%) 5.00 <0.00> (ø)
src/ActionExecutor/Basic.php 80.00% <0.00%> (-2.36%) 19.00 <0.00> (ø)
src/ActionExecutor/UserAction.php 42.00% <0.00%> (-0.16%) 95.00 <0.00> (ø)
src/App.php 81.72% <0.00%> (-0.45%) 147.00 <0.00> (ø)
src/Button.php 85.00% <0.00%> (+4.04%) 8.00 <0.00> (ø)
src/Callback.php 90.47% <0.00%> (ø) 17.00 <0.00> (ø)
src/CallbackLater.php 75.00% <0.00%> (ø) 3.00 <0.00> (ø)
src/CardTable.php 91.66% <0.00%> (-3.99%) 9.00 <0.00> (ø)
src/Console.php 80.14% <0.00%> (-2.34%) 46.00 <0.00> (ø)
src/Exception/NoRenderTree.php 0.00% <0.00%> (ø) 2.00 <0.00> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59506b...853a83b. Read the comment docs.

@DarkSide666 DarkSide666 merged commit fbcd5db into atk4:develop Jun 6, 2020
@mvorisek mvorisek deleted the fix_ex_arr branch June 6, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants