Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing DIContainerTrait when StaticAddToTrait is used #1251

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Fix missing DIContainerTrait when StaticAddToTrait is used #1251

merged 1 commit into from
Jun 7, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 7, 2020 •
edited
Loading

Refactor code for atk4/core#221

fully documented behaviour that DIContainerTrait trait much be used when StaticAddToTrait is used

@mvorisek mvorisek mentioned this pull request Jun 7, 2020
Merged
@codecov
Copy link

codecov bot commented Jun 7, 2020 •
edited
Loading

Codecov Report

Merging #1251 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1251   +/-   ##
==========================================
  Coverage      72.35%   72.35%           
  Complexity      2556     2556           
==========================================
  Files            130      130           
  Lines           6313     6313           
==========================================
  Hits            4568     4568           
  Misses          1745     1745
Impacted Files Coverage Δ Complexity Δ
src/Template.php 92.11% <ø> (ø) 101.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e31a1...a83dc81. Read the comment docs.

@mvorisek mvorisek requested a review from DarkSide666 June 7, 2020 11:23
@mvorisek mvorisek closed this Jun 7, 2020
@mvorisek mvorisek deleted the fix_for_new_factory branch June 7, 2020 12:17
@mvorisek mvorisek restored the fix_for_new_factory branch June 7, 2020 12:51
@ibelar ibelar mentioned this pull request Jun 7, 2020
Merged
@mvorisek mvorisek reopened this Jun 7, 2020
@mvorisek mvorisek added the RTM label Jun 7, 2020
romaninsh
romaninsh approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvorisek mvorisek merged commit 23067a5 into atk4:develop Jun 7, 2020
@mvorisek mvorisek deleted the fix_for_new_factory branch June 7, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @romaninsh